Re: [PATCH?] uprobes: change uprobe_write_opcode() to modify the page directly

From: Linus Torvalds
Date: Tue Dec 03 2013 - 17:01:59 EST


On Tue, Dec 3, 2013 at 12:54 PM, Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
>
> So do you think the patch I sent is wrong? Why?

I think the TLB shootdown should guarantee that it's ok on other
CPU's, since that's basically what we do on mmap.

But looking closer at this, I think I see why the old code did what it
did. I think it's breaking shared mmap pages on purpose rather than
dirtying them. Which is probably the right thing to do.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/