Re: [PATCH 2/2] perf probe: Allow user to specify address withinexecutable

From: David Ahern
Date: Tue Dec 03 2013 - 10:58:17 EST


On 12/3/13, 2:24 AM, Masami Hiramatsu wrote:
> I don't want to make perf-probe just a wrapper of the ftrace dynamic
> event interface, because it doesn't add any "value" for users.

Sure it does -- a consistent user experience in using a single command
(perf probe ...) for setting up userspace probes.

Specifying the address directly is really on par with perf-record having
the rNNN interface for directly passing the raw event id to the kernel.

>
>>>> In that case, you should use uprobe_events interface directly.
>>>
>>> How do I do that within the context of perf?
>
> No way, but here, you can save this script as perf-uprobe and
> can use it for that purpose. :)

I figured out what you meant by uprobe_events interface yesterday. If I
have to go to that interface for even 1 function I would do it for all
-- from a user perspective it is just simpler to have 1 command to setup
probes. I would prefer that 1 command be perf-probe.

David

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/