Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

From: Greg KH
Date: Tue Dec 03 2013 - 09:29:32 EST


On Tue, Dec 03, 2013 at 02:35:17PM +0100, Frank Haverkamp wrote:
> > > +/* common struct for chip image exchange */
> > > +struct chip_bitstream {
> > > + uint8_t __user *pdata; /* pointer to image data */
> > > + int size; /* size of image file */
> >
> > I think this fails the 32/64bit issue, right?
>
> Yes. I replaced those by something like
> __u32 data_addr;
> I hope that is fixing the 32/64bit issue.

No, not at all, how are you going to put a 64bit userspace pointer in
there?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/