Re: [PATCH] HID: logitech-dj: add HIDRAW dependency in Kconfig

From: Jiri Kosina
Date: Tue Dec 03 2013 - 07:51:57 EST


On Tue, 3 Dec 2013, Olivier Gay wrote:

> Without hidraw driver, we get this:
>
> <3>[ 210.131988] logitech-djreceiver 0003:046D:C52B.0005: claimed by
> neither input, hiddev nor hidraw
> <3>[ 210.132202] logitech-djreceiver 0003:046D:C52B.0005:
> logi_dj_probe:hid_hw_start returned error
>
> In logi_dj_probe, we call hid_hw_start with HID_CONNECT_DEFAULT
> argument and if hidraw driver is not present, the call fails and we
> return an error in logi_dj_probe.
>
> > It's clear that without hidraw it's not possible to change the pairing
> > from userspace, but I fail to see why probing the receiver should be
> > affected?
>
> As of today, hid-logitech-dj.c depends on hidraw API to work. All HID
> reports sent to control / configure the receiver are sent using hidraw
> API. That's why we fail logi_dj_probe if we cannot connect to hidraw.

Hmm, so unifying receiver is not claimed by hid-input at all?
(HID_CONNECT_DEFAULT also contains HID_CONNECT_HIDINPUT) How so?

(again, I will not be able to test it with my receiver up until the day
after tomorrow).

Thanks,

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/