Re: [PATCH v12 06/18] vmscan: rename shrink_slab() args to make itmore generic

From: Dave Chinner
Date: Tue Dec 03 2013 - 05:04:35 EST


On Tue, Dec 03, 2013 at 01:44:38PM +0400, Vladimir Davydov wrote:
> On 12/03/2013 01:33 PM, Dave Chinner wrote:
> >> kmemcg reclaim is introduced, we will have to make up phony values for
> >> nr_pages_scanned and lru_pages again when doing kmem-only reclaim for a
> >> memory cgroup, which is possible if the cgroup has its kmem limit less
> >> than the total memory limit.
> > I'm missing something here - why would memcg reclaim require
> > passing phony values? How are you going to keep slab caches in
> > balance with memory pressure generated by the page cache?
>
> To perform kmem-only reclaim - please see patch 13. When the kmem limit
> is less than the user limit, we can reach only the kmem limit. It is no
> use trying to reclaim page cache then.

Oh dear. What a nasty hack.

Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/