[PATCH] sysfs: add necessary Null check in sysfs_do_create_link_sd

From: Rui Xiang
Date: Mon Dec 02 2013 - 20:39:31 EST


While target_sd or sd are null, it won't need sysfs_put and
should return -ENOENT directly. Here add null check for
target_sd and sd.

Signed-off-by: Rui Xiang <rui.xiang@xxxxxxxxxx>
---
fs/sysfs/symlink.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/fs/sysfs/symlink.c b/fs/sysfs/symlink.c
index 3ae3f1b..d69b786 100644
--- a/fs/sysfs/symlink.c
+++ b/fs/sysfs/symlink.c
@@ -83,8 +83,10 @@ static int sysfs_do_create_link_sd(struct sysfs_dirent *parent_sd,
return 0;

out_put:
- sysfs_put(target_sd);
- sysfs_put(sd);
+ if (target_sd)
+ sysfs_put(target_sd);
+ if (sd)
+ sysfs_put(sd);
return error;
}

--
1.8.2.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/