Re: [PATCH 1/5] serial: 8250_pci: use DEFINE_PCI_DEVICE_TABLE macro

From: Jonas Bonn
Date: Mon Dec 02 2013 - 05:43:49 EST

Hi Joe,

On 12/02/2013 06:48 AM, Joe Perches wrote:
(Adding Jonas Bonn to list as he added the macro in the first place...)

Thanks... ;)

Actually, I think I submitted an even uglier macro called DECLARE_PCI_DEVICE_TABLE... might have been the first kernel patch I ever sent? In any case, it should certainly have been kindly rejected. After it hit mainline Andrew Morton just about choked on his tea and renamed it DEFINE_PCI_DEVICE_TABLE.


On Mon, 2013-12-02 at 13:03 +0900, Jingoo Han wrote:
On Monday, December 02, 2013 12:56 PM, Guenter Roeck wrote:
On 12/01/2013 07:50 PM, Jingoo Han wrote:
On Monday, December 02, 2013 12:46 PM, Guenter Roeck wrote:
On 12/01/2013 04:07 PM, Jingoo Han wrote:
On Friday, November 29, 2013 10:34 AM, Jingoo Han wrote:
On Thursday, November 28, 2013 3:24 PM, Joe Perches wrote:
On Wed, 2013-11-27 at 21:53 -0800, 'Greg Kroah-Hartman' wrote:
On Wed, Nov 27, 2013 at 09:40:13PM -0800, Joe Perches wrote:
On Thu, 2013-11-28 at 14:29 +0900, Jingoo Han wrote:
On Thursday, November 28, 2013 1:08 PM, Greg Kroah-Hartman wrote:
On Thu, Nov 28, 2013 at 10:55:35AM +0900, Jingoo Han wrote:
This macro is used to create a struct pci_device_id array.

Yeah, and it's a horrid macro that deserves to be removed, please don't
use it in more places.

Actually, if you could just remove it, that would be best, sorry, I'm
not going to take these patches.


Feel free to just remove the macro; it serves no purpose but to confuse. That said, the underlying issue that the macro was supposed to resolve (if I recall correctly) was to make sure that all the struct pci_device_id instances were marked as const, as per the PCI documentation; if there's something checkpatch should be warning for it's simply that the struct is const.

/Jonas

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/