Re: [PATCH] rtc: rtc-at91rm9200: Corrected alarm over day/month wrap:

From: Nicolas Ferre
Date: Mon Dec 02 2013 - 03:28:15 EST


On 18/11/2013 23:37, Andrew Morton :
On Mon, 18 Nov 2013 18:20:54 +0100 Nicolas Ferre <nicolas.ferre@xxxxxxxxx> wrote:

From: Linus Pizunski <linus@xxxxxxxxxxxxxxxxx>

Update month and day of month to the alarm month/day instead
of current day/month when setting the RTC alarm mask.

Signed-off-by: Linus Pizunski <linus@xxxxxxxxxxxxxxxxx>
Acked-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxx>

I changed this to signed-off-by, as you were on the patch delivery path.

--- a/drivers/rtc/rtc-at91rm9200.c
+++ b/drivers/rtc/rtc-at91rm9200.c
@@ -220,6 +220,8 @@ static int at91_rtc_setalarm(struct device *dev, struct rtc_wkalrm *alrm)

at91_alarm_year = tm.tm_year;

+ tm.tm_mon = alrm->time.tm_mon;
+ tm.tm_mday = alrm->time.tm_mday;
tm.tm_hour = alrm->time.tm_hour;
tm.tm_min = alrm->time.tm_min;
tm.tm_sec = alrm->time.tm_sec;

I queued this for 3.13. Do we think it warrants a -stable backport?

(I am late, but it seems this one is not sent to Linus yet...)

Well, yes, we can tag this one for "-stable". The patch applies on nearly each kernel that I can think about (code is from 2.6.17-ish). But this patch applies with an offset...

Best regards,
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/