Re: [PATCHv1] ASoC: SGTL5000: Fix kernel failed while gettingregulator consumers

From: Mark Brown
Date: Wed Nov 27 2013 - 06:27:48 EST


On Wed, Nov 27, 2013 at 08:13:03AM +0000, Li Xiubo wrote:

Please fix your mailer to word wrap within paragraphs, it makes your
mail much more legible.

> There is one dependency patch: "regulator: core: Provide a dummy regulator with full constraints".

> From the dependency patch, we can see that using regulator_get_optional() instead can resovle the problem you descripted above.

> When or will this dependency patch be merged into the -next tree ?

That patch is already in mainline.

> > I'd expect to see a commit description that describes how the driver
> > currently tries to handle this, why it doesn't work and how the patch
> > fixes it.

> The SGTL5000 requires 2 external power supplies: VDDA and VDDIO. An
> optional third external power supply VDDD may be provided externally

You need to put your working through of this stuff in the commit
message.

Attachment: signature.asc
Description: Digital signature