Re: Fwd: [PATCH 7/8] watchdog: davinci: add "clocks" property

From: Arnd Bergmann
Date: Sat Nov 23 2013 - 12:58:29 EST


On Wednesday 06 November 2013, ivan.khoronzhuk wrote:
> @@ -7,6 +7,10 @@ Required properties:
>
> - reg : Should contain WDT registers location and length
>
> +- clocks: phandle reference to the controller clock.
> + Required only for Keystone arch.
> + See clock-bindings.txt
> +
> Optional properties:
>
> - timeout-sec: Contains the watchdog timeout in seconds

I think it should really be listed under "Optional properties" and the
reference to Keystone removed. Note how the binding would need
to change otherwise if another platform started to use the clock, which
is a little silly.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/