Re: [PATCH 3/8] perf symbol: Save vmlinux or kallsyms path loaded
From: David Ahern
Date: Fri Nov 22 2013 - 14:14:04 EST
On 11/22/13, 11:44 AM, Arnaldo Carvalho de Melo wrote:
Em Mon, Nov 18, 2013 at 01:32:46PM -0700, David Ahern escreveu:
Save vmlinux or kallsyms path loaded using embedded default lookup (ie.,
not a user specified path). Upcoming perf sched timehist command requires
kernel symbols for properly computing idle times and prints a warning
if the kernel symbols are not loaded.
What would happen if strdup failed here?
perf continues on happily. On the timehist command will question
computation of idle times which require kernel symbols.
Why don't we undo anything done so far in this function and return an
error?
In the notion of best effort of continuing. It's not a show stopper that
strdup failed; it's just not the filename it used for symbols.
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/