Re: [lm-sensors] [PATCH] hwmon: (max6650) Add support for gpiodef

From: Laszlo Papp
Date: Fri Nov 22 2013 - 09:50:55 EST


On Fri, Nov 22, 2013 at 2:35 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> On 11/22/2013 01:23 AM, Laszlo Papp wrote:
>>
>> Just to clarify: you want to have ./gpio/gpio-max6650.c?
>>
> No, I never said that. I wanted you to register the gpio pins
> with the gpio subsystem. I didn't ask you to write a separate
> driver for it.
>
> Sure, strictly speaking one could write a top level mfd driver
> and separate gpio and hwmon drivers, but at least in my opinion
> that would be overkill. I also never suggested this; you brought
> the term mfd into the discussion.

Why is it an overkill to write a separate gpio driver for this, and
potentially also for the gpio status register of this particular MAXIM
chip?

Other gpio drivers in the gpio folder are also short. This would not
become long either.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/