Re: [PATCH v3 2/5] extcon: max14577: Add extcon-max14577 driver tosupport MUIC device

From: Krzysztof Kozlowski
Date: Fri Nov 22 2013 - 06:34:36 EST


On Fri, 2013-11-22 at 10:35 +0000, Mark Brown wrote:
> On Fri, Nov 22, 2013 at 09:46:09AM +0100, Krzysztof Kozlowski wrote:
>
> > +#define DELAY_MS_DEFAULT 17000 /* unit: millisecond */
>
> This delay is sufficiently large that the delayed work using it probably
> ought to use the power efficient workqueues instead of just a regular
> schedule_delayed_work(). This will mean that instead of being scheduled
> on the core which scheduled it the work can run on any CPU, avoiding the
> need to power up a currently idle CPU just to run the work.

I'll fix this. Thanks for review of the patches.

Best regards,
Krzysztof


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/