Re: [PATCH] tty: replace mutex_lock() with tty_write_lock()

From: Dan Carpenter
Date: Fri Nov 22 2013 - 03:25:39 EST


On Thu, Nov 21, 2013 at 08:12:12PM +0100, Andreas Platschek wrote:
> Use tty_write_lock()/tty_write_unlock() consistently.
>
> This takes care of the following sparse warning:
> drivers/tty/tty_io.c:1169:17: warning: context imbalance in 'tty_write_message' - unexpected unlock
>

I don't think we can do this. mutex_lock() always succeeds and
tty_write_lock() can fail.

I think we just have to live with the error message.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/