Re: [PATCH 04/11] vfs: add renameat2 syscall

[Stephen Rothwell]

Hi all,

On Wed, 20 Nov 2013 14:01:45 +0100 Miklos Szeredi <miklos@xxxxxxxxxx> wrote:
>
> From: Miklos Szeredi <mszeredi@xxxxxxx>
> 
> Add new renameat2 syscall, which is the same as renameat with an added
> flags argument.
> 
> Pass flags to vfs_rename() and to i_op->rename() as well.
> 
> All filesystems check flags and return -EOPNOTSUPP for unsupported flags.

Can we please consider doing this slightly slower (and avoiding
conflicts/missed new uses etc) by creating a new i_op callback and only
implementing this when necessary?

From past experience, I can just about guarantee that the patch as it is
will cause conflicts (for me in linux-next if noone else) and a new use
case will turn up before (or during) the next merge window.

-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx

Attachment: pgp00000.pgp
Description: PGP signature