Re: [PATCH 1/1] Workaround for Suspend/Resume issue of AX88772Bunder ChromeOS

From: David Miller
Date: Wed Nov 20 2013 - 00:40:35 EST


From: freddy@xxxxxxxxxxx
Date: Wed, 20 Nov 2013 10:11:36 +0800

> From: Freddy Xin <freddy@xxxxxxxxxxx>
>
> This patch adds a workaroud to solve Suspend/Resume issue that AX88772B turns
> off its Ethernet PHY power in the case that REMOTE_WAKEUP feature doesn't
> be set when system suspend. In this case, the PHY power will not be turned
> on again when system resume, so the HW reset must be added in the resume function.
>
> Signed-off-by: Freddy Xin <freddy@xxxxxxxxxxx>
> Tested-by: Grant Grundler <grundler@xxxxxxxxxxxx>

Like many similar patches I've seen recently, you cannot do this.

Now the the configuration that software things the PHY has is no
longer accurate.

If you absolutely must reset the chip on resume, you have to reprogram
the PHY with whatever settings were existed at the time of the suspend.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/