Re: [PATCH] Expose sysctls for enabling slab/file_cache interleaving

[Andi Kleen]

Michal Hocko <mhocko@xxxxxxx> writes:
>
> Another option would be to use sysctl values for the top cpuset as a
> default. But then why not just do it manually without sysctl?

I want to provide an alternative to having to use cpusets to use this,
that is actually usable for normal people.

Also this is really a global setting in my mind.

> If you create a cpuset and explicitly disable spreading then you would
> be quite surprised that your process gets pages from all nodes, no?

If I enable it globally using a sysctl I would be quite surprised 
if some cpuset can override it.

That argument is equally valid :-)

The user configured an inconsistent configuration, and the kernel
has to make a decision somehow.

In the end it is arbitary, but not having to check the cpuset
here is a lot cheaper, so I prefer the "sysctl has priority" 
option.

Could EINVAL the cpuset setting when the sysctl is set
though (but it's difficult to do the other way round).

-Andi

-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/