Re: [PATCH 9/9] staging/lustre/ldlm: fix resource/fid check, useDLDLMRES

From: Greg Kroah-Hartman
Date: Tue Nov 19 2013 - 13:40:39 EST


On Tue, Nov 19, 2013 at 09:23:48PM +0800, Peng Tao wrote:
> From: Andreas Dilger <andreas.dilger@xxxxxxxxx>
>
> In ll_md_blocking_ast() the FID/resource comparison is incorrectly
> checking for fid_ver() stored in res_id.name[2] instead of name[1]
> changed since http://review.whamcloud.com/2271 (commit 4f91d5161d00)
> landed. This does not impact current clients, since name[2] and
> fid_ver() are always zero, but it could cause problems in the future.
>
> In ldlm_cli_enqueue_fini() use ldlm_res_eq() instead of comparing
> each of the resource fields separately.
>
> Use DLDLMRES/PLDLMRES when printing resource names everywhere.

There are codingstyle warnings in this patch, please fix before
resending.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/