Re: [PATCH] Expose sysctls for enabling slab/file_cache interleaving

[Michal Hocko]

On Mon 18-11-13 16:50:22, Andi Kleen wrote:
[...]
> diff --git a/include/linux/cpuset.h b/include/linux/cpuset.h
> index cc1b01c..10966f5 100644
> --- a/include/linux/cpuset.h
> +++ b/include/linux/cpuset.h
> @@ -72,12 +72,14 @@ extern int cpuset_slab_spread_node(void);
>  
>  static inline int cpuset_do_page_mem_spread(void)
>  {
> -	return current->flags & PF_SPREAD_PAGE;
> +	return (current->flags & PF_SPREAD_PAGE) ||
> +		sysctl_spread_file_cache;
>  }

But this might break applications that explicitly opt out from
spreading.

>  
>  static inline int cpuset_do_slab_mem_spread(void)
>  {
> -	return current->flags & PF_SPREAD_SLAB;
> +	return (current->flags & PF_SPREAD_SLAB) || 
> +		sysctl_spread_slab;
>  }
>  
>  extern int current_cpuset_is_being_rebound(void);
[...]
-- 
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/