Re: [PATCH] x86: boot: Fix mixed indentation in a20.c

[Borislav Petkov]

On Tue, Nov 19, 2013 at 08:22:41AM +0100, Ingo Molnar wrote:
> 
> * H. Peter Anvin <hpa@xxxxxxxxx> wrote:
> 
> > On 11/18/2013 09:50 AM, Johannes LÃthberg wrote:
> > > Replace all mixed indentation with tabs
> > > 
> > > Signed-off-by: Johannes LÃthberg <johannes@xxxxxxxxxxxx>
> > 
> > NAK.  Not worth the churn in the absence of other changes.
> 
> Yes.
> 
> If a20.c was cleaned up altogether, that might be a more tempting 
> change, it has a good number of inconsistencies and improving it all 
> would make it more readable.
>  
> But it makes little sense to do an incomplete cleanup.

Yeah, senseless cleanup without any benefit whatsoever (yeah, fuck
readability! :-)) should be forbidden, if you ask me. Especially
since it dilutes and muds up git history and finding the patch which
introduced a change turns into a serious undertaking.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/