Re: [PATCH v2 1/2] xen: vnuma support for PV guests running as domU

From: Elena Ufimtseva
Date: Mon Nov 18 2013 - 16:28:45 EST


On Mon, Nov 18, 2013 at 4:14 PM, H. Peter Anvin <hpa@xxxxxxxxx> wrote:
> On 11/18/2013 12:25 PM, Elena Ufimtseva wrote:
>> +/* Checks if hypercall is supported */
>> +bool xen_vnuma_supported()
>
> This isn't C++...
>
> http://lwn.net/Articles/487493/
>
> There are several more things in this patchset that get flagged by
> checkpatch, but apparently this rather common (and rather serious)
> problem is still not being detected, even through a patch was submitted
> almost two years ago:
>
> https://lkml.org/lkml/2012/3/16/510

Thank you Peter, good to know. Will resend these.
>
> -hpa
>
>



--
Elena
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/