Re: [PATCH] bio: fix argument of __bio_add_page() for max_sectors> 0xffff

[Jens Axboe]

On 11/18/2013 06:11 AM, Akinobu Mita wrote:
> The data type of max_sectors and max_hw_sectors in queue settings are
> unsigned int.  But these values are passed to __bio_add_page() as an
> argument whose data type is unsigned short.  In the worst case such as
> max_sectors is 0x10000, bio_add_page() can't add a page and IOs can't
> proceed.

Thanks, added. Even at 512b sectors, 0xffff sectors would be a huuuuge
page. So I don't think we'd ever see this bug hit, iirc huge pages are
still broken down for IO. But it's better to be safe...
-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/