Re: [PATCH v6 3/5] qrwlock: Enable fair queue read/write lock

[Linus Torvalds]

On Mon, Nov 18, 2013 at 10:46 AM, Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
>> Why would it make sense here?
>
> There may be cases were switching all read locks to unfair may make
> concerete workloads slower.

Sorry, but I don't believe in "may be" as an excuse for complexity.
Especially since the "may be" faster performance is often coupled with
"known latency problems due to unfairness".

I'd want numbers for real loads if we really want the extra complexity.

Right now, the real numbers I can point to is in the size of the
patch, and the extra code complexity. Yes, I see the microbenchmark
numbers, but those are pretty much irrelevant to real loads.

                    Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/