Re: [patch] perf/trace properly use u64 to hold event_id

From: Peter Zijlstra
Date: Mon Nov 18 2013 - 03:53:55 EST


On Fri, Nov 15, 2013 at 12:39:45PM -0500, Vince Weaver wrote:
>
> The 64-bit attr.config value for perf trace events was being copied into
> an "int" before doing a comparison, meaning the top 32 bits were
> being truncated.
>
> As far as I can tell this didn't cause any errors, but it did mean
> it was possible to create valid aliases for all the tracepoint ids
> which I don't think was intended. (For example, 0xffffffff00000018
> and 0x18 both enable the same tracepoint).
>
> Signed-off-by: Vince Weaver <vincent.weaver@xxxxxxxxx>

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/