Re: [PATCH] brcmsmac: Fix build dep on LEDS_CLASS
From: Arend van Spriel
Date: Sun Nov 17 2013 - 16:31:44 EST
On 11/17/13 14:37, Borislav Petkov wrote:
From: Borislav Petkov<bp@xxxxxxx>
When building randconfigs with CONFIG_BCMA_DRIVER_GPIO=y, I get
drivers/built-in.o: In function `brcms_led_unregister':
(.text+0x351aca): undefined reference to `led_classdev_unregister'
drivers/built-in.o: In function `brcms_led_register':
(.text+0x351c65): undefined reference to `led_classdev_register'
during the final linking stage because brcmsmac/led.c needs LEDS_CLASS
for reg/dereg. Fix that.
Wouldn't it be better to fix it in brcmsmac.
Gr AvS
Cc: "RafaÅ MiÅecki"<zajec5@xxxxxxxxx>
Cc: linux-wireless@xxxxxxxxxxxxxxx
Signed-off-by: Borislav Petkov<bp@xxxxxxx>
---
I'm attaching the .config in question.
drivers/bcma/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
index 7c081b38ef3e..74dba9ca1413 100644
--- a/drivers/bcma/Kconfig
+++ b/drivers/bcma/Kconfig
@@ -74,7 +74,7 @@ config BCMA_DRIVER_GMAC_CMN
config BCMA_DRIVER_GPIO
bool "BCMA GPIO driver"
- depends on BCMA&& GPIOLIB
+ depends on BCMA&& GPIOLIB&& LEDS_CLASS
help
Driver to provide access to the GPIO pins of the bcma bus.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/