Re: [REGRESSION] coredumps truncated after "new helper: dump_align()"

[Al Viro]

On Fri, Nov 15, 2013 at 03:26:10PM +0100, Peter Wu wrote:
> Hi Al,
> 
> Somewhere in the merge window of 3.13, coredumps appear truncated.
> Instead of 319488 bytes, I get 868 bytes (tested with x86_64 only).
> 
> The latest Linus' master (v3.12-9579-g049ffa8) is still affected.
> Bisection leads to:
> 
> commit 22a8cb8248ba5d340307ba72432253b1dbdb5cf7
> Author: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> Date:   Tue Oct 8 11:05:01 2013 -0400
> 
>     new helper: dump_align()
>     
>     dump_skip to given alignment...

Argh...  Really dumb braino when getting rid of long long division in
dump_align().  Please, see if this gets rid of the entire problem on your
setup - it definitely fixes a bug in there and it seems to restore the
normal behaviour on the reproducer I've got here, but...

I'm going to send that to Linus, along with another coredump fix
(dump_emit() ought to use __kernel_write() instead of vfs_write())
shortly anyway, but if you spot anything still broken...

diff --git a/fs/coredump.c b/fs/coredump.c
index 62406b6..a2856f7 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -733,7 +733,7 @@ int dump_align(struct coredump_params *cprm, int align)
 {
 	unsigned mod = cprm->written & (align - 1);
 	if (align & (align - 1))
-		return -EINVAL;
-	return mod ? dump_skip(cprm, align - mod) : 0;
+		return 0;
+	return mod ? dump_skip(cprm, align - mod) : 1;
 }
 EXPORT_SYMBOL(dump_align);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/