Re: [PATCH] rtc: rtc-ds1742: Add devicetree support

[Mark Rutland]

On Thu, Nov 14, 2013 at 12:32:42PM +0000, Alexander Shiyan wrote:
> This patch allows the driver to be enabled with devicetree.
> 
> Signed-off-by: Alexander Shiyan <shc_work@xxxxxxx>
> ---
>  Documentation/devicetree/bindings/rtc/maxim,ds1742.txt | 14 ++++++++++++++
>  drivers/rtc/rtc-ds1742.c                               | 10 +++++++++-
>  2 files changed, 23 insertions(+), 1 deletion(-)
>  create mode 100644 Documentation/devicetree/bindings/rtc/maxim,ds1742.txt
> 
> diff --git a/Documentation/devicetree/bindings/rtc/maxim,ds1742.txt b/Documentation/devicetree/bindings/rtc/maxim,ds1742.txt
> new file mode 100644
> index 0000000..d2ddd71
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/maxim,ds1742.txt
> @@ -0,0 +1,14 @@
> +* Maxim (Dallas) DS1742/DS1743 Real Time Clock
> +
> +Register a Maxim DS1742-compatible RTC.

The driver registration has nothing to do with the binding.

Either add a brief description of the device or remove this line
entirely.

> +
> +Required properties:
> +- compatible: Should be "maxim,ds1742".

s/be/contain/

> +- reg: Physical base address of the RTC and length of memory
> +  mapped region.
> +
> +Example:
> +	rtc: rtc@10000000 {
> +		compatible = "maxim,ds1742";
> +		reg = <0x10000000 0x800>;
> +	};

Otherwise this binding looks fine to me, with those changes.

Acked-by: Mark Rutland <mark.rutland@xxxxxxx>

Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/