Re: [PATCH 4/4] arm64: advertise CPU features for modalias matching

From: Ard Biesheuvel
Date: Thu Nov 14 2013 - 11:14:53 EST


On 14 November 2013 16:29, Catalin Marinas <catalin.marinas@xxxxxxx> wrote:
> On Mon, Nov 11, 2013 at 10:19:35AM +0000, Ard Biesheuvel wrote:
>> +ssize_t arch_print_cpu_modalias(struct device *dev,
>> + struct device_attribute *attr,
>> + char *buf)
>> +{
>> + unsigned int caps;
>> + ssize_t n;
>> + int i;
>> +
>> + /*
>> + * With 32 features maximum (taking 5 bytes each to print), we don't
>> + * need to worry about overrunning the PAGE_SIZE sized buffer.
>> + */
>> + n = sprintf(buf, "cpu:type:arm64:feature:");
>
> I would use "aarch64" here instead of arm64 for consistency with the
> architecture mode, compiler triplet and ELF_PLATFORM definition in the
> kernel.

OK, I will change that.

Regards,
Ard,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/