Re: [PATCH] nfsd:add '\n' when read file supported_krb5_enctypes

[J. Bruce Fields]

On Thu, Nov 14, 2013 at 08:38:55PM +0800, Weng Meiling wrote:
> On 2013/11/14 0:09, J. Bruce Fields wrote:
> > On Fri, Nov 08, 2013 at 03:23:28PM +0800, Weng Meiling wrote:
> >>
> >> From: Weng Meiling <wengmeiling.weng@xxxxxxxxxx>
> > 
> > I agree completely that a \n at the end would make more sense.
> > 
> > Have you tested that this nfs-utils is OK with this change?
> > 
> > I suspect that the only code that reads this file anywhere is
> > 
> > 	nfs-utils/utils/gssd/svcgssd_krb5.c:parse_enctypes()
> > 
> > And on a quick skim of that function.... I *think* it should be fine.
> > But I'd be happier if you could confirm that you've tested it.
> > 
> > --b.
> > 
> After this changeï starting the nfs serverï other host can use the
> server's shared files normally :-).

I don't see how that tests parse_enctypes().

--b.

> 
> Thanksï
> Weng Meilling
> >>
> >> Signed-off-by: Weng Meiling <wengmeiling.weng@xxxxxxxxxx>
> >> ---
> >>  fs/nfsd/nfsctl.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
> >> index 7f55517..31db42c 100644
> >> --- a/fs/nfsd/nfsctl.c
> >> +++ b/fs/nfsd/nfsctl.c
> >> @@ -188,7 +188,7 @@ static const struct file_operations export_features_operations = {
> >>  #if defined(CONFIG_SUNRPC_GSS) || defined(CONFIG_SUNRPC_GSS_MODULE)
> >>  static int supported_enctypes_show(struct seq_file *m, void *v)
> >>  {
> >> -	seq_printf(m, KRB5_SUPPORTED_ENCTYPES);
> >> +	seq_printf(m, "%s\n", KRB5_SUPPORTED_ENCTYPES);
> >>  	return 0;
> >>  }
> >>
> >> -- 
> >> 1.8.3.1
> >>
> >>
> >>
> >>
> > 
> > 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/