Re: [PATCH 01/03] gpio: rcar: Use lazy disable and mask on suspend

[Magnus Damm]

Hi Laurent,

On Thu, Nov 14, 2013 at 11:17 AM, Laurent Pinchart
<laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
> Hi Magnus,
>
> On Thursday 14 November 2013 11:03:06 Magnus Damm wrote:
>> On Thu, Nov 14, 2013 at 9:07 AM, Laurent Pinchart wrote:
>> > On Thursday 14 November 2013 07:59:36 Magnus Damm wrote:
>> >> From: Magnus Damm <damm@xxxxxxxxxxxxx>
>> >>
>> >> Set the ->irq_enable() and ->irq_disable() methods to NULL
>> >> to enable lazy disable of interrupts.
>> >
>> > Is that just for optimization purpose, or is there another reason ?
>>
>> It is needed for IRQCHIP_MASK_ON_SUSPEND operation, which in turn is
>> needed for Suspend-to-RAM.
>>
>> >> Also extend the code to set IRQCHIP_MASK_ON_SUSPEND which tells the core
>> >> that only IRQs marked as wakeups need to stay enabled during
>> >> Suspend-to-RAM.
>> >
>> > Shouldn't this be split to a separate patch ?
>>
>> I could split them up, but since there is a dependency and since I
>> mainly care about making sure Suspend-to-RAM works I preferred to keep
>> them together.
>
> Fine with me. Could you then please update the commit message to mention that
> lazy disabling is required for IRQCHIP_MASK_ON_SUSPEND ? Same comment for
> patch 03/03.

Since when is it common practise to describe the dependencies for the
various components included in a single commit? My opinion is that the
person reading the code if requiring more information will have to
grep for IRQCHIP_MASK_ON_SUSPEND in the friendly source code and learn
how the subsystem is held together.

In the case you have some special detailed commit message that you
would like me to use then please feel free to propose that. If not
then I will then split up the patches.

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/