Re: [PATCH] dma-debug: enhance dma_debug_device_change() to check formapping errors

From: Shuah Khan
Date: Tue Nov 12 2013 - 17:21:24 EST


On 11/12/2013 03:12 PM, Alexander Duyck wrote:
I think this might be overdoing the error checking by a bit. I would
much rather have the DMA leaked error be visible than have it buried
under messages about the failure to check for DMA errors. In my mind
the DMA buffer leak is much more serious than the failure to check for
mapping errors.


I agree DMA leak message is more important. Would you like to see just one message if mapping errors are found? Instead of printing the entire stacktrace like it does now, it could just do warn.

-- Shuah


--
Shuah Khan
Senior Linux Kernel Developer - Open Source Group
Samsung Research America(Silicon Valley)
shuah.kh@xxxxxxxxxxx | (970) 672-0658
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/