Re: [PATCH 2/2] kallsyms: Revert back to 128 max symbol length

From: Joe Mario
Date: Tue Nov 12 2013 - 16:56:36 EST


On 11/11/2013 09:17 AM, Andi Kleen wrote:
On Mon, Nov 11, 2013 at 02:40:36PM +0100, Michal Marek wrote:
This reverts commits
f3462aa (Kbuild: Handle longer symbols in kallsyms.c) and
eea0e9c (kbuild: Increase kallsyms max symbol length)
except for the added overflow check. The reason is a regression caused
by increasing the buffer:
http://marc.info/?l=linux-kernel&m=138387700415675.

Can you please wait a bit until we tracked down the problem?


-Andi


Andi:
Don Zickus and I have been trying to reproduce the problem with
the config file Fengguang Wu sent to us, but so far have been unsuccessful.

Given there are 5 other locations in the code that need to be changed
from [128] to [KSYM_NAME_LEN], and that we still haven't found Fengguang's
problem yet, I'd be in favor of letting Michal's revert patch 2/2 go forward.

That would give us time to find the issue Fengguang reported.

Joe




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/