[PATCH] x86/smpboot: Make the code more consistent

From: Ingo Molnar
Date: Tue Nov 12 2013 - 07:39:48 EST



* Borislav Petkov <bp@xxxxxxxxx> wrote:

> On Tue, Nov 12, 2013 at 12:37:10PM +0100, Ingo Molnar wrote:
> > Hm, I think it's actually a bonus that we see the individual CPUs
> > printed as they boot up. That way if there's a hang, the place where
> > it hangs is apparent, etc.
>
> Ok, good point.
>
> We can do something like that then:
>
> [ 0.068574] x86: Booting SMP configuration:
> [ 0.069006] .... node #1, CPUs: #1
> [ 0.147005] .... node #0, CPUs: #2 #3
> [ 0.147005] .... node #1, CPUs: #4 #5
> [ 0.445273] x86: Booted up 2 nodes, 6 CPUs
>
> and report (node, core) in the order they appear.

Btw., while looking at the code I found various pieces of hard to read
code, with inconsistent coding principles all across the spectrum.

Mind applying the attached cleanup patch first, before doing fixes to the
printout? No change in functionality. Mildly tested.

Thanks,

Ingo

================>