Re: [PATCH 4/5] OF: Export all DT proc update functions

From: Pantelis Antoniou
Date: Tue Nov 12 2013 - 05:21:13 EST


Hi Grant,

On Nov 11, 2013, at 5:09 PM, Grant Likely wrote:

> On Tue, 5 Nov 2013 19:50:15 +0200, Pantelis Antoniou <panto@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
>> There are other users for the proc DT functions.
>> Export them.
>>
>> Signed-off-by: Pantelis Antoniou <panto@xxxxxxxxxxxxxxxxxxxxxxx>
>
> These are all very much internal DT APIs. There is no way that anything
> outside of drivers/of should ever be calling them. (In fact, I want to
> be rid of the /proc/devicetree implementation entirely and put it into
> sysfs, but that is a separate patch set). If they need to be broken out
> into a header file, can they be put into something like
> drivers/of/of_private.h?
>

That's fine by me.

I can move them to of_private.h, no problem there.

> g.
>

Regards

-- Pantelis

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/