Re: [PATCH] of: set dma_mask to point to coherent_dma_mask

From: Grant Likely
Date: Tue Nov 12 2013 - 02:05:14 EST


On Mon, 11 Nov 2013 16:59:14 +0000, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> On Wed, 6 Nov 2013, Stefano Stabellini wrote:
> > On Sat, 2 Nov 2013, Grant Likely wrote:
> > > On Wed, 30 Oct 2013 00:05:22 -0500, Rob Herring <robherring2@xxxxxxxxx> wrote:
> > > > From: Rob Herring <rob.herring@xxxxxxxxxxx>
> > > >
> > > > Platform devices created by DT code don't initialize dma_mask pointer to
> > > > anything. Set it to coherent_dma_mask by default if the architecture
> > > > code has not set it.
> > > >
> > > > Signed-off-by: Rob Herring <rob.herring@xxxxxxxxxxx>
> > >
> > > I believe this is okay. I haven't done any testing to back up that
> > > opinion though.
> >
> > Tested-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
>
> BTW I hope you are planning on sending this upstream soon, because
> without it I can very easily corrupt my root fs by simply booting the system.

Gah! That's pretty nasty. It is in Rob's for-next branch, but it hasn't
been marked for backporting to stable. Best thing to do here is for
either you or Rob to repost the patch to stable@xxxxxxxxxxxxxxx and
include the commit id from Rob's tree. It's not upstream yet, but it
will be soon.

How far back in kernel releases do you want the patch backported to?

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/