Re: [PATCHv2 2/2] check quirk to pad epout buf size when not alignedto maxpacketsize

[David Cohen]

On 11/11/2013 03:21 AM, Michal Nazarewicz wrote:
> Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires
> to be aligned to maxpacketsize of an out endpoint.  ffs_epfile_io() needs
> to pad epout buffer to match above condition if quirk is found.
>
> Signed-off-by: Michal Nazarewicz <mina86@xxxxxxxxxx>
> ---
>   drivers/usb/gadget/f_fs.c | 23 +++++++++++++++++++----
>   1 file changed, 19 insertions(+), 4 deletions(-)
>
> > On 11/10/2013 08:50 AM, Michal Nazarewicz wrote:
> > > @@ -787,6 +788,13 @@ static ssize_t ffs_epfile_io(struct file *file,
> > >
> > >   	/* Allocate & copy */
> > >   	if (!halt) {
> > > +		/*
> > > +		 * Controller requires buffer size to be aligned to
> > > +		 * maxpacketsize of an out endpoint.
> > > +		 */
> > > +		data_len = read && gadget->quirk_ep_out_aligned_size ?
> > > +			usb_ep_align_maxpacketsize(ep->ep, len) : len;
> > > +
> > >   		data = kmalloc(len, GFP_KERNEL);
>
> On Mon, Nov 11 2013, David Cohen <david.a.cohen@xxxxxxxxxxxxxxx> wrote:
> > Shouldn't this kmalloc() allocate 'data_len' bytes, instead of 'len'?
>
> Yes, of coures.

Thanks. It looks fine. I'll test these patches now.

But the whole series became messy with too many amends. If you don't 
mind, I'll send a v5 of my patch set including my v4.1 patches + your 2
ones following the correct sequence.

Br, David Cohen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/