Re: [PATCH 3/3] panic: enable local IRQs for restart timeout too

[Ingo Molnar]

* Felipe Contreras <felipe.contreras@xxxxxxxxx> wrote:

> On Mon, Nov 11, 2013 at 7:19 AM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
> >
> > * Felipe Contreras <felipe.contreras@xxxxxxxxx> wrote:
> >
> >> Signed-off-by: Felipe Contreras <felipe.contreras@xxxxxxxxx>
> >
> > The changelog is missing and the title is not self-explanatory.
> 
> Either the local IRQs should be enabled for both the restart and halt
> blinks, or it shouldn't be enabled for either. Why enable them for
> halt, but not restart?
> 
> I think enabling them for restart too makes sense.

Such arguments belong into the changelog, with a description of what was 
done before and what is done after - please use the customary (verbose) 
changelog style we use in the kernel.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/