Re: [PATCH 2/3] panic: improve panic_timeout calculation

[Felipe Contreras]

On Mon, Nov 11, 2013 at 6:49 AM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
> * Felipe Contreras <felipe.contreras@xxxxxxxxx> wrote:
>
>> On Mon, Nov 11, 2013 at 5:32 AM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>> >
>> > * Felipe Contreras <felipe.contreras@xxxxxxxxx> wrote:
>> >
>> >> We want to calculate the blinks per second, and instead of making it 5
>> >> (1000 / (3600 / 18)), let's make it 4, so the user can see two blinks
>> >> per second.
>> >
>> > Please use the customary changelog style we use in the kernel:
>> >
>> >   " Current code does (A), this has a problem when (B).
>> >     We can improve this doing (C), because (D)."
>>
>> A is explained, B is empty, C is explained, D is because it makes sense.
>
> NAKed-by: Ingo Molnar <mingo@xxxxxxxxxx>

Suit yourself, stay with your buggy code then.

Patch #1 is the important one anyway.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/