Re: [kallsyms] general protection fault: 0000 [#1] PREEMPT DEBUG_PAGEALLOC

[Michal Marek]

On 10.11.2013 16:23, Andi Kleen wrote:
> On Sun, Nov 10, 2013 at 05:40:05PM +0800, Fengguang Wu wrote:
>> Hi Joe,
>>
>> FYI. Here is another bisect result.
> 
> I bet it's that strncpy() in kallsyms.c and someone passing in a too
> short buffer on a 32bit kernel.
> 
> We should really kill strncpy(), it's just evil.

I'm testing a patch for include/linux/pci.h to use line numbers instead
of the PCI ID macros to declare the __pci_fixup_* symbols. If that
works, we can revert the limit back to 128 and only keep the check in
kallsyms.c.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/