Re: [PATCH 4/4] perf record: mmap output file - v3

From: Ingo Molnar
Date: Mon Nov 11 2013 - 06:53:19 EST



* David Ahern <dsahern@xxxxxxxxx> wrote:

> >>+do_mmap:
> >>+ offset = rec->session->header.data_offset + rec->bytes_written;
> >>+ if (offset < (ssize_t) rec->mmap_out_size) {
> >>+ rec->mmap_offset = offset;
> >>+ offset = 0;
> >>+ } else
> >>+ rec->mmap_offset = 0;
> >
> >(Nit: unbalanced curly braces.)
>
> I believe checkpatch.pl complains, but will add.

Hm, if that is so then please report that to the checkpatch folks, the
warning is bogus and causes worse code to be written.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/