Re: [PATCH] perf tool: Round mmap pages to power 2

[Ingo Molnar]

* David Ahern <dsahern@xxxxxxxxx> wrote:

> Currently perf requires the -m / --mmap_pages option to be a power of 2.
> To be more user friendly perf should automatically round this up to the
> next power of 2.
> 
> Currently:
>   $ perf record -m 3 -a -- sleep 1
>   --mmap_pages/-m value must be a power of two.sleep: Terminated
> 
> With patch:
>   $ perf record -m 3 -a -- sleep 1
>   rounding mmap pages size to 16384 (4 pages)

Please add 'bytes'.

I'd also suggest generally prefixing tooling messages with some sort of 
'subsystem' prefix, so that in the great and rich network of perf tooling 
subsystems the user knows roughly where the message comes from.

Here it should probably be something like:

    INFO: ring-buffer: Rounding mmap pages size to 16384 bytes (4 pages)

?

While if the message was related to evlists for example and was a hard 
error, it would have this pattern:

    ERROR: event-list: ...

while if it's a warning, it would say:

    WARNING: event-list: ...

I.e. we could match how the kernel handled printk()d message types, 
priorities and subsystems.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/