Re: [PATCH] regmap: Fix compile warning with value uninitialized

[Greg Kroah-Hartman]

On Sat, Nov 09, 2013 at 04:34:07PM +0100, Levente Kurusa wrote:
> 2013-11-09 16:16 keltezéssel, Mark Brown írta:
> > On Sat, Nov 09, 2013 at 09:49:11AM +0000, Caizhiyong wrote:
> > 
> >> @@ -2170,7 +2170,8 @@ int regmap_register_patch(struct regmap *map, const struct reg_default *regs,
> >>  			  int num_regs)
> >>  {
> >>  	struct reg_default *p;
> >> -	int i, ret;
> >> +	int i;
> >> +	int ret = 0;
> >>  	bool bypass;
> Wouldn't the following be better?
> 
> int i, ret = 0;
> 
> I think it is more readable.

No, please put them on separate lines like the patch did.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/