Re: [PATCH v4 5/5] OF: Introduce utility helper functions

From: Guenter Roeck
Date: Fri Nov 08 2013 - 14:10:47 EST


On Fri, Nov 08, 2013 at 05:04:00PM +0200, Pantelis Antoniou wrote:
> Introduce helper functions for working with the live DT tree.
>
> __of_free_property() frees a dynamically created property
> __of_free_tree() recursively frees a device node tree
> __of_copy_property() copies a property dynamically
> __of_create_empty_node() creates an empty node
> __of_find_node_by_full_name() finds the node with the full name
> and
> of_multi_prop_cmp() performs a multi property compare but without
> having to take locks.
>
> Bug fix about prop->len == 0 by Ionut Nicu <ioan.nicu.ext@xxxxxxx>
>
> Signed-off-by: Pantelis Antoniou <panto@xxxxxxxxxxxxxxxxxxxxxxx>

Hi Pantelis,

nitpick:

.git/rebase-apply/patch:77: trailing whitespace.
* no pointer exist for any properties. Only safe to do if you
.git/rebase-apply/patch:213: trailing whitespace.
* Find a node with the give full name by recursively following any of
.git/rebase-apply/patch:274: new blank line at EOF.
+
warning: 3 lines add whitespace errors.

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/