Re: [PATCH] ARM: Use udiv/sdiv for __aeabi_{u}idiv libraryfunctions

From: Russell King - ARM Linux
Date: Fri Nov 08 2013 - 11:52:40 EST


On Fri, Nov 08, 2013 at 10:58:42AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 11:20 Thu 07 Nov , Stephen Boyd wrote:
> > @@ -381,6 +384,13 @@ static void __init cpuid_init_hwcaps(void)
> > elf_hwcap |= HWCAP_IDIVT;
> > }
> >
> > +#ifdef CONFIG_THUMB2_KERNEL
> if (IS_ENABLED(CONFIG_THUMB2_KERNEL) && elf_hwcap & HWCAP_IDIVT)
> > + if (elf_hwcap & HWCAP_IDIVT)
> > +#else
> > + if (elf_hwcap & HWCAP_IDIVA)
> > +#endif

Take another look, and you'll see the change that you're suggesting is
wrong. Instead, the following may be a more reasonable suggestion as
a suitable replacement:

if (elf_hwcap & (IS_ENABLED(CONFIG_THUMB2_KERNEL) ?
HWCAP_IDIVT : HWCAP_IDIVA))
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/