Re: [PATCH v2 0/7] perf timechart improvements

[Namhyung Kim]

Hi Arnaldo and Stanislav,

2013-11-06 (ì), 14:48 -0300, Arnaldo Carvalho de Melo:
> Em Wed, Nov 06, 2013 at 05:07:19PM +0900, Namhyung Kim escreveu:
> > Hi Arnaldo,
> > 
> > On Tue, 5 Nov 2013 14:28:12 -0300, Arnaldo Carvalho de Melo wrote:
> > > Em Fri, Nov 01, 2013 at 08:25:44PM +0400, Stanislav Fomichev escreveu:
> > >> This patch series adds more features to the perf timechart command:
> > >> * -n option that adds possibility to limit number of tasks on SVG
> > >> * -T option that adds possibility to show only tasks related info
> > >> * -T and -P options now work with `perf timechart record` command to keep
> > >>   perf.data small
> > >> * -g option that adds possibility to record and add callchain to the SVG so
> > >>   it's now possible to understand why some task went to sleep or what code
> > >>   path woke it up
> > >> * add titles to the SVG blocks so it's possible to see how long task is
> > >>   running/sleeping/blocked
> > >> 
> > >> v2:
> > >> * fix errors pointed out by Namhyung Kim <namhyung@xxxxxxxxxx>
> > >
> > > Namhyung, are you ok now? Acked-by?
> > 
> > Not having time to review this yet.  I think I can do it tomorrow.
> 
> Ok, just asked because you provided comments on a previous patchkit
> version.

It seems to address all of my previous concerns, so

Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Thanks,
Namhyung




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/