Re: [PATCH 1/1] cpufreq: cpufreq-cpu0: use the max voltage insteadof voltage-tolerance

[Shawn Guo]

On Thu, Nov 07, 2013 at 01:55:21AM +0000, Rongjun Ying wrote:
> > For given board, what voltages could be provided is known.  So you can
> > just define OPP table in <board>.dts and specify the voltage as the
> > value that the regulator IC can supply, e.g. 1.200V in above example.
> > 
> > This is not nice, as OPP table is CPU/SoC specific and should be
> > ideally defined in <soc>.dtsi.  But still it's a way out for you to use
> > cpufreq-cpu0 driver as it is.
> > 
> > In any case, you can not just change voltage-tolerance to voltage-max
> > with no care about the existing users.
> > 
> > Shawn
> > 
> I don't think so. The voltage/freq pairs are attribute of the CPU.
> Any boards can choose regulator IC base the cost and other reasons.
> If the opp table defined in <board>.dts, we can set exact voltage/freq pairs,
> and not need use the voltage-tolerance to set tolerance.

If you read my comment above, you should see that I agree OPP is
CPU/SoC specific and should be defined in <soc>.dtsi.  But property
operating-points can reasonably be overwritten by particular <board>.dts
for some reason like some voltages cannot be supplied on that board.

Again, this is just a way for you to use generic cpufreq-cpu0 driver as
it is, but not necessarily the best one.

Shawn

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/