RE: [PATCH -next] mtd: nand: omap: fix error return code inomap_nand_probe()

From: Gupta, Pekon
Date: Wed Nov 06 2013 - 13:07:50 EST


> From: Brian Norris [mailto:computersforpeace@xxxxxxxxx]
> > On Thu, Oct 31, 2013 at 7:18 PM, Jingoo Han <jg1.han@xxxxxxxxxxx>
> >> From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
> >>
> >> Fix to return a negative error code from the error handling
> >> case instead of 0, as done elsewhere in this function.
> >
> > Commit message is right? :-(
>
> It sounds OK by my reading. Unless you're having trouble parsing what
> "as done elsewhere in this function" is being applied to. (IOW, is the
> rest of the function returning a negative error code on the error
> paths, or is it returning 0? Of course the answer is the former, but
> it's possible to misread it.) If it helps, I can try to tweak the
> wording a bit when applying this patch.
>
> Pekon, can I get an Acked-by?
>
Yes sure .. Sorry I was away from both mailbox and boards.
Acked-by: Pekon Gupta <pekon@xxxxxx>

And thanks much Wei Yongjun for fixing this .


with regards, pekon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/