Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v4)

From: Frank Haverkamp
Date: Mon Nov 04 2013 - 11:47:23 EST


Hi Ryan,

Am Donnerstag, den 31.10.2013, 14:49 +1100 schrieb Ryan Mallon:
> > +/**
> > + * create_card_sysfs() - Setup sysfs entries of the card device
> > + *
> > + * VFs have restricted mmio capabilities, so not all sysfs entries
> > + * are allowed in VFs.
> > + */
> > +int create_card_sysfs(struct genwqe_dev *cd)
>
> This is extern, and has a very generic name. Prefix it with genwqe or
> something. Same for the function below, and for any other extern
> symbols
> you have.

Good finding. I fixed that in the course of the other sysfs reworks too.
Thanks for pointing it out.

Regards

Frank

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/