Re: [PATCH v2] dynamic_debug: add wildcard support to filterfiles/functions/modules
From: Joe Perches
Date: Thu Oct 31 2013 - 19:31:48 EST
On Thu, 2013-10-31 at 15:52 -0700, Andrew Morton wrote:
> On Mon, 28 Oct 2013 23:29:10 +0800 "Du, Changbin" <changbin.du@xxxxxxxxx> wrote:
> > +/* check if the string matches given pattern which includes wildcards */
> > +static int match_pattern(const char *pattern, const char *string)
> No, something like this should be in lib/ so that other callers can use
> it. We already have at least one copy handy in
> drivers/ata/libata-core.c:glob_match(). A better approach would be to
> move that glob_match() into lib/glob_match.c then teach dynamic_debug
> to use it.
> There are probably other private globbing functions lying around the
> kernel, but it's rather a hard thing to grep for...
Maybe use lib/parser.c where the other match_<foo> functions
match_glob has the disadvantage that it's recursive too.
kernel/trace/trace_events_filter.c:static int regex_match_full(char *str, struct regex *r, int len)
kernel/trace/trace_events_filter.c:static int regex_match_front(char *str, struct regex *r, int len)
kernel/trace/trace_events_filter.c:static int regex_match_middle(char *str, struct regex *r, int len)
kernel/trace/trace_events_filter.c:static int regex_match_end(char *str, struct regex *r, int len)
but there probably aren't many more that could be converted.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/