Re: [PATCH] xfs: fix possible NULL dereference

From: Geyslan Gregório Bem
Date: Thu Oct 31 2013 - 12:16:04 EST


2013/10/31 Ben Myers <bpm@xxxxxxx>:
> Hey Geyslan,
>
> On Wed, Oct 30, 2013 at 03:08:12PM -0500, Eric Sandeen wrote:
>> On 10/23/13 3:34 PM, Ben Myers wrote:
>>
>> > xfs: fix possible NULL dereference in xlog_verify_iclog
>> >
>> > In xlog_verify_iclog a debug check of the incore log buffers prints an
>> > error if icptr is null and then goes on to dereference the pointer
>> > regardless. Convert this to an assert so that the intention is clear.
>> > This was reported by Coverty.
>> >
>> > Reported-by: Geyslan G. Bem <geyslan@xxxxxxxxx>
>> > Signed-off-by: Ben Myers <bpm@xxxxxxx>
>>
>> Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
>
> Applied this. Many thanks! ;)
>
> -Ben

It was a pleasure. o/

--
Regards,

Geyslan G. Bem
hackingbits.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/